Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: improve Crashlytics support for Kotlin Native #10030

Open
rickclephas opened this issue Jul 20, 2022 · 0 comments
Open

FR: improve Crashlytics support for Kotlin Native #10030

rickclephas opened this issue Jul 20, 2022 · 0 comments

Comments

@rickclephas
Copy link

Feature proposal

  • Firebase Component: Crashlytics

Kotlin handles exceptions quite differently from Swift/ObjC.
We can already map a Kotlin Exception to a FIRExceptionModel,
but there are currently 2 missing APIs to fully support Kotlin Native:

  1. FIRExceptionModel doesn't have an API to store the cause of an exception.
  2. there is currently no way to manually record a fatal exception.
    In case an unhandled Kotlin exception reaches ObjC, Kotlin will terminate the program. This results in a SIGABRT crash in Crashlytics. There is a hook so it would be great if we could manually record the fatal exception.

I think adding the following APIs would suffice:

@interface FIRExceptionModel ()

@property(nonatomic, nullable) FIRExceptionModel *cause;

@end

@interface FIRCrashlytics ()

- (void)recordFatalException:(FIRExceptionModel *)exceptionModel;

@end

I have been playing with this and IMO nr 2 should be fairly straight forward.
All the logic is there we just need to expose the API.

For nr 1 I am not sure about the impact. It seems like the iOS SDK doesn't know the caused by concept, but on the other hand the Crashlytics backend does (since it's common for Android).

Would love to make a contribution, but I wouldn't know where to start (especially for nr 1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants