Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Developer Connect API client #6887

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Add Developer Connect API client #6887

merged 2 commits into from
Mar 19, 2024

Conversation

mathu97
Copy link
Contributor

@mathu97 mathu97 commented Mar 18, 2024

Description

Similar to the Cloud Build Client, this is a helper that will make working with the Developer Connect API easier.

@mathu97 mathu97 requested a review from tonyjhuang March 18, 2024 21:34
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 61.53846% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 54.30%. Comparing base (95f3fad) to head (d8841df).

Files Patch % Lines
src/gcp/devConnect.ts 59.45% 14 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6887      +/-   ##
==========================================
+ Coverage   54.28%   54.30%   +0.01%     
==========================================
  Files         352      353       +1     
  Lines       24539    24578      +39     
  Branches     5082     5086       +4     
==========================================
+ Hits        13322    13346      +24     
- Misses      10005    10019      +14     
- Partials     1212     1213       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathu97 mathu97 enabled auto-merge (squash) March 18, 2024 21:41
nextPageToken?: string;
}>(`/projects/${projectId}/locations/${location}/connections`, {
queryParams: {
pageSize: PAGE_SIZE_MAX,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems at odds with fetchLinkableGitRespositories() below, is PAGE_SIZE_MAX intended to be the max value or the default value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is intended to be max value. The maximum number of items per page. But this is a good point, I will update fetchLinkableGitRepositories to have behave similar to this function.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have a listConnections vs listAllConnections?

@mathu97 mathu97 merged commit c76e863 into master Mar 19, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants