fix(ui_auth): emit UserCreated state when signed in user is new #10225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-Mais
approved these changes
Jan 6, 2023
Lyokone
reviewed
Jan 6, 2023
| @@ -144,7 +144,11 @@ class AuthFlow<T extends AuthProvider> extends ValueNotifier<AuthState> | |||
|
|
|||
| @override | |||
| void onSignedIn(UserCredential credential) { | |||
| value = SignedIn(credential.user); | |||
| if (credential.additionalUserInfo?.isNewUser ?? false) { | |||
There was a problem hiding this comment.
Is this new state being possible documented somewhere else?
There was a problem hiding this comment.
it's not new, UserCreated was there from the very beginning
Lyokone
approved these changes
Jan 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check for additional user info and emit
UserCreatedwhencredential.additionalUserInfo?.isNewUseris trueRelated Issues
Closes #10124
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?