Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Existing profiles from vernier fail to load #5368

Open
vladimirtcats opened this issue Feb 13, 2025 · 2 comments · May be fixed by #5369
Open

Existing profiles from vernier fail to load #5368

vladimirtcats opened this issue Feb 13, 2025 · 2 comments · May be fixed by #5369
Assignees
@mstange

Comments

@vladimirtcats
Copy link

vladimirtcats commented Feb 13, 2025 •
edited by data-sync-user
Loading

Hi everyone

When I click links

https://share.firefox.dev/3Ld89id
https://share.firefox.dev/3DhLsFa

on the readme page(https://github.com/jhawthorn/vernier?tab=readme-ov-file) I get error:
Uh oh, some unknown error happened in profiler.firefox.com.

TypeError: Cannot read properties of null (reading '0').
Please report this issue to the developers, including the full error as displayed in the Developer Tools’ Web Console.

┆Issue is synchronized with this Jira Task
@canova
Copy link
Member

canova commented Feb 13, 2025

Looks like these vernier profiles don't include subcategory fields inside frameTables. After the changes in #5342, we are now throwing an error.

The error comes from here:

profiler/src/profile-logic/profile-data.js

Line 4159 in 3e62ca1

const frameSubcategory = frameTable.subcategory[frameIndex];

Interestingly in the profile types, subcategories were never optional:

profiler/src/types/profile.js

Line 262 in 3e62ca1

subcategory: (IndexIntoSubcategoryListForCategory | null)[],

So the current profiler code is technically correct, but probably we were trying to be more careful before and not throwing an error. Ideally it would be good if vernier could fix the problem on their side. But that won't fix the older profiles that are captured already.

@mstange should we add an upgrader for the older profiles, or should we try to check it's presence directly?

@mstange
Copy link
Contributor

mstange commented Feb 13, 2025

Ah interesting, I think we can just tweak the existing upgrader a bit. I'll give it a try.

@mstange mstange mentioned this issue Feb 13, 2025
Open
mstange added a commit to mstange/perf.html that referenced this issue Feb 13, 2025
@mstange
Extend the workaround in the v53 upgrader to generate missing subcate…
5ae2cd7 
…gory columns.

Fixes firefox-devtools#5368.
@mstange mstange linked a pull request Feb 13, 2025 that will close this issue
Open
@mstange mstange changed the title An error occurred in Firefox Profiler Existing profiles from vernier fail to load Feb 13, 2025
@mstange mstange self-assigned this Feb 13, 2025
mstange added a commit to mstange/perf.html that referenced this issue Feb 14, 2025
@mstange
Extend the workaround in the v53 upgrader to generate missing subcate…
217755f 
…gory columns.

Fixes firefox-devtools#5368.
mstange added a commit to mstange/perf.html that referenced this issue Feb 14, 2025
@mstange
Extend the workaround in the v53 upgrader to generate missing subcate…
aa8354e 
…gory columns.

Fixes firefox-devtools#5368.
@joshuay03 joshuay03 mentioned this issue Feb 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mstange mstange

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extend the workaround in the v53 upgrader to generate missing subcategory columns. mstange/perf.html
3 participants
@canova @mstange @vladimirtcats