-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Support Turtlecoin's Algorithm Change #1227
Comments
Just to pre-empt the requirements check: Website: https://turtlecoin.lol/ The hashrate hovers around a baseline of 6MH/s. (https://blocks.turtle.link/#) |
As well since Turtlecoin is borrowing from the Aeon rebase of V1 Cryptonight-lite I believe that there should be a standard Cryptonight_liteV1 option under stak 3.1 as there is a high likelihood that other currency’s will switch or new ico will arrive with this protocol. Thank you for your consideration @FireIceUK |
Awesome |
Update: Turtlecoin has set the upgrade height to 350,000. https://github.com/turtlecoin/turtlecoin/commit/9517d1e62a6e4195977bfde5b90b60b173155ce3. That is approximately 15 April 2018. |
@sumlnoether Thanks for the good description. I will add this coin today night. |
@psychocrypt Thank you! |
Thanks @psychocrypt @fireice-uk |
The test pool is providing blocks with the version |
The time table has a little bit shifted. I will add |
Thanks for pointing it out. I'm looking into it right now. |
After tracking the problem down, I found that it wasn't a pool problem at all. Our code from legacy bytecoin performs the hashing on something called a 'parent block' which is required to be major version 1. https://github.com/turtlecoin/turtlecoin/blob/master/src/CryptoNoteCore/Core.cpp#L1043 Thus, that 0100 first two bytes has to be passed in the job blob to the miners. This means that it is impossible to distinguish between pre-fork and post-fork hashing blobs. The only way is to look at the entire block template which is only known to the pool. Could we propose that instead of automatically switching the algorithms, Turtlecoin will simply have one algorithm under xmr-stak: Cryptonight-light variant 1? We will direct our miners to use the 'monero' option before the fork and manually switch to 'turtlecoin' after. Thank you so much, |
In that case we can maybe (need to speak with @fireice-uk) implement only
the post fork algo. Never the less the turtle code should be changed to
support future forks. IMO it is very bad for the miner that they need to
switch the algorithm by hand in the right moment.
Turtle should use the hard fork to fix this issu.
|
@psychocrypt We're looking at doing that in the future but right now the hard fork is too close to achieve consensus. |
@sumlnoether Ok. We will do that. Bear in mind that this will mean your coin's hashrate will fall to nearly zero for 24 hrs or so. If you need some help with bytecoin code feel free to get in touch =). |
Thank you so much. Our coin has already forked actually. The scheduled was pushed up by someone with a lot of hashrate. We saw a dip to about 1/4 - 1/3rd the old hashrate but it's going at an average of 6-7 MH/s of CN Lite variant 1 and rising. Currently, most of the miners are using xmrig or their own hastily patched versions of xmr-stak. |
Has XMR-STAK been updated to support this yet, or is it a future thing? |
Made a PR to add turtlecoin as a named option. #1469 |
as I know turtle is using cryptonight_lite_v7. Choose the correct algorithm
and you can mine turtle.
|
I can confirm that it works fine. Thanks for the 2.4.3 update. |
Yep, it works perfectly now. Just thought it would be nice for our users to have it as an option. |
Introduction
Turtlecoin will be making an algorithm switch in response to the ASIC threat as detailed in this Medium post by @RocksteadyTC: https://medium.com/@turtlecoin/what-is-the-deal-with-asic-d22b86510c6 and an ongoing discussion here: https://github.com/turtlecoin/meta/issues/74.
This change is projected to happen mid-April.
We would like to request that Turtlecoin be added to the list of supported coins in xmr-stak's list.
Technical Details
Currently, Turtlecoin uses the standard Cryptonight (or Monerov6) as it's proof of work function.
It will be moving to Cryptonight-Lite Variant 1 (or the Aeonv1 algorithm) during the hard fork.
Block Major Versions
Block Major Version 1-3: Cryptonight
Block Major Version 4: Cryptonight-Lite Variant 1
Test Hashes
The following hashes are in the format:
Cryptonight (Courtesy of Monero)
Found here: https://github.com/sumlnoether/turtlecoin/blob/8ada1c291f7ae8f3c025c7e42a50be963adc1ce3/tests/Hash/tests-cn-v6.txt
Cryptonight-Lite Variant 1 (Courtesy of xmrig)
Found here: https://github.com/sumlnoether/turtlecoin/blob/8ada1c291f7ae8f3c025c7e42a50be963adc1ce3/tests/Hash/tests-cn-lite-v1.txt
Test Pool
The community (thank you, DiscoTim) has also set up a pool for our testnet at https://trtltest.mine2gether.com/.
It is currently on block major version 4 and thus accepts Cryptonight-Lite Variant 1 hashes.
It has been tested and verified to work with the Ubuntu 16.04 build of xmrig-2.5.2. A test command for xmrig is as follows:
Conclusions
Thank you for reading through this feature request.
References
Turtlecoin Algorithm Change PR: https://github.com/turtlecoin/turtlecoin/pull/119
Turtlecoin Pool Algorithm Change PR: https://github.com/turtlecoin/turtle-pool/pull/7
Turtlecoin node-multi-hashing https://github.com/turtlecoin/node8-multi-hashing
Turtlecoin node-cryptonote-util https://github.com/turtlecoin/node-cryptonote-util
The text was updated successfully, but these errors were encountered: