Feature/0.18 node selectors #118
Conversation
| @@ -192,7 +192,7 @@ <h6> | |||
| class="field-input form-control input-dark" | |||
| ng-model="selectorService.selection.dirty.include" | |||
| placeholder="..." /> | |||
| <div class="field-label">--models</div> | |||
| <div class="field-label">--select</div> | |||
There was a problem hiding this comment.
note: this changes the --models label to --select, which feels appropriate if not 100% accurate all of the time. Probably something we should give more thought to for a future iteration of this UI
There was a problem hiding this comment.
I agree with this change. It feels right to have the DAG mirror the behavior and syntax of dbt ls. And as Jake pointed out to me (not long ago), dbt ls --models ... is basically dbt ls --resource-type model --select.
There was a problem hiding this comment.
heroic
- intersections ✅
- nth parent/child ✅
- config, package method ✅
- test_name, test_type ❔
test_type:dataworks finetest_nameis exclusive to schema tests (implicitly, I think, by requiringtest_metadata)- separate conversation, not for this PR: When (if ever) should the DAG include schema test nodes?
This PR does not support YML-based selectors
Is this for another PR, or do you have a feeling against supporting YML-defined selectors in the DAG view?
I sort of follow how the tests run in netlify: if netlify runs make dist-ci, and the deployment succeeded, and the tests run before webpack, the tests must also have succeeded. In any case, I ran them locally, and they look good.
| @@ -192,7 +192,7 @@ <h6> | |||
| class="field-input form-control input-dark" | |||
| ng-model="selectorService.selection.dirty.include" | |||
| placeholder="..." /> | |||
| <div class="field-label">--models</div> | |||
| <div class="field-label">--select</div> | |||
There was a problem hiding this comment.
I agree with this change. It feels right to have the DAG mirror the behavior and syntax of dbt ls. And as Jake pointed out to me (not long ago), dbt ls --models ... is basically dbt ls --resource-type model --select.
Yeah... i kind of punted on that question. I think adding them as "nodes" in the DAG might not be quite right, but i do think there should be a way to visualize tests on nodes in the DAG view? Definitely one to ponder.
We can totally do that in a separate PR... we should sync up about how to make that happen for the 0.18.0 release re: tests: yeah, i'm just using the makefile here. We should probably set this up with a circle workflow than run tests before kicking off the netlify build. Low impact low priority at the moment IMO :D |
fixes #116
The DAG view now supports:
This PR does not support YML-based selectors
Additionally, I added a bunch of graph-related tests and hooked them up to run in netlify on push