Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to hub for installation instructions #144

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Conversation

clrcrl
Copy link
Contributor

@clrcrl clrcrl commented Jun 20, 2019

These installation instructions are notably much lighter than what was here before, since I've also opened a PR on the Hub site to add some instructions there.

If you're happy with this copy, I'll use it across all the packages we have on Hub – so expect lots of similar PRs :)

One thing to consider is that when you view this README on the hub site, it will have two sets of installation instructions 🤷‍♀

@clrcrl clrcrl requested a review from drewbanin June 20, 2019 20:17
@clrcrl
Copy link
Contributor Author

clrcrl commented Jun 20, 2019

idk why this is failing 😭

@drewbanin
Copy link
Contributor

can you try merging master into your branch, then pushing again?

@clrcrl clrcrl force-pushed the refactor/readme branch from 729c69b to acb3d12 Compare June 20, 2019 20:27
@clrcrl
Copy link
Contributor Author

clrcrl commented Jun 20, 2019

my bad – I rebased off master, but forgot to git pull first. Tests passing now 👍

Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor copy nit, take it or leave it. Approved either way!

README.md Outdated Show resolved Hide resolved
@clrcrl clrcrl force-pushed the refactor/readme branch from fccc30d to 8999a07 Compare June 21, 2019 16:19
@drewbanin drewbanin merged commit 99e755b into master Jun 21, 2019
@clrcrl clrcrl deleted the refactor/readme branch March 19, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants