Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "unpivot" macro #72

Merged
merged 12 commits into from
Jul 20, 2018
Merged

Conversation

dwallace0723
Copy link
Contributor

This macro adds functionality similar to pandas melt function. It essentially "un-pivots" a table from wide-format to long-format.

@drewbanin drewbanin self-requested a review July 20, 2018 00:23
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwallace0723 this looks great! Do you think you'd be able to make an integration test for it? The key benefit of the test is that we'd be able to catch regressions if this macro is ever updated in the future.

Really nice work!

Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! :shipit:

@drewbanin drewbanin merged commit afd04b0 into dbt-labs:master Jul 20, 2018
@dwallace0723 dwallace0723 deleted the add-unpivot-macro branch July 20, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants