Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hrplib/hrpCollision] enable to bypass normal vector correction #141

Merged
merged 2 commits into from
Apr 10, 2019

Conversation

fkanehiro
Copy link
Owner

This PR enables to bypass normal vector correction in hrpCollision.
The normal vector correction sometimes remove normal vectors to get better normal vectors for contact force calculation.
If it is disabled, hrpCollision can be used as an usual collision detection library.

@fkanehiro
Copy link
Owner Author

@orikuma
Please try this.
The normal vector correction function can be disabled by calling ColdetModelPair::enableNormalVectorCorrection().

@fkanehiro
Copy link
Owner Author

@orikuma
What do you think about this?

@orikuma
Copy link
Contributor

orikuma commented Apr 10, 2019

I prefer this change but I think we need to update dpkg to pass travis before merging this PR.
(cf. #143 ).

@fkanehiro fkanehiro merged commit 9e999a1 into master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants