Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict Mode Supported #388

Closed
IceSentry opened this issue Sep 4, 2019 · 11 comments
Closed

Strict Mode Supported #388

IceSentry opened this issue Sep 4, 2019 · 11 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@IceSentry
Copy link

Do you want to request a feature or report a bug?

bug

What is the current behavior?

When enabling Strict Mode the console receives a few errors related to using findDOMNode()

What is the expected behavior?

No error in the console when using Strict Mode

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

React: 16.9
Browser: N/A

Are there any plans to migrate to newer React API's to make Strict Mode work?

@fkhadra
Copy link
Owner

fkhadra commented Nov 7, 2019

Hello @IceSentry,

The library don't use findDOMNode directly. This is used by react-transition-group. I'll see if they have any plan to migrate from it.

Thank you

@fkhadra fkhadra added the dependencies Pull requests that update a dependency file label Nov 7, 2019
@crobinson42
Copy link

When this issue is closed in react-transition-group we can update the dependency version in this lib: reactjs/react-transition-group#559

@fkhadra
Copy link
Owner

fkhadra commented Nov 11, 2019

@crobinson42 thank you for linking the issue appreciate

@WPaczula
Copy link

There is an updated version of that issue on the react-transition-group: reactjs/react-transition-group#606

@fkhadra
Copy link
Owner

fkhadra commented Apr 22, 2020

Thanks @WPaczula

@fkhadra fkhadra pinned this issue Apr 22, 2020
@darklight9811
Copy link

Is there a workaround? The toasts won't even display for me.

@ifier
Copy link

ifier commented May 1, 2020

Still happens :(

@fkhadra
Copy link
Owner

fkhadra commented May 1, 2020

The guys of react-transition-group are working really hard to address this issue(PR here). This should land soon.

  • Strict mode run in development mode only, this should not impact your production code.
  • The toast should display even with strict mode @darklight9811
  • You should only see a warning with strict mode until the issue is fixed.

Below an example of react-toastify working in strict mode.

Edit relaxed-water-ov9it

@fkhadra
Copy link
Owner

fkhadra commented May 5, 2020

The new RC of react-toastify support strict mode 🔥. You can install it as follow:
yarn add react-toastify@next or npm i react-toastify@next

I expect to launch the stable release next week if there is no bug.

@fkhadra fkhadra changed the title Support Strict Mode Strict Mode Supported Now ! May 5, 2020
@fkhadra fkhadra changed the title Strict Mode Supported Now ! Strict Mode Supported almost ! May 6, 2020
@fkhadra
Copy link
Owner

fkhadra commented May 6, 2020

There is a really weird bug when a single notification is displayed the exit transition is not triggered. I'll investigate that bug later

@fkhadra fkhadra changed the title Strict Mode Supported almost ! Strict Mode Supported May 9, 2020
@fkhadra
Copy link
Owner

fkhadra commented May 10, 2020

Everything has been fixed for strict mode.

@fkhadra fkhadra closed this as completed May 10, 2020
@fkhadra fkhadra unpinned this issue May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

6 participants