Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use poetry for dependency Management #1343

Open
maringuu opened this issue Feb 6, 2025 · 0 comments
Open

Use poetry for dependency Management #1343

maringuu opened this issue Feb 6, 2025 · 0 comments

Comments

@maringuu
Copy link
Collaborator

maringuu commented Feb 6, 2025

Currently, we have several requirements.txt files:

At least for the four non-plugin files dependencies, we could unify them in the pyproject.toml using poetry.
To represent the individual files we could use poetry groups.

Advantages:

  • Unified dependency
  • Automatic creation of a lockfile
  • Automatic creation of a project specific venv
  • Packaging support (If we decide to implement Create Python Package #882)

Disadvantages:

  • Dependency on poetry

I consider this issue resolved if the following is fulfilled:

  • All non-plugin-specific dependencies are defined using poetry
  • A pre-commit hook is added to check validity of the poetry.lock and pyproject.toml
  • The CI runs the above hook
  • The CI uses the poetry.lock file

See also #1335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant