Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add noscript #27

Open
toastal opened this issue Oct 27, 2023 · 7 comments · May be fixed by #42
Open

Add noscript #27

toastal opened this issue Oct 27, 2023 · 7 comments · May be fixed by #42

Comments

@toastal
Copy link

toastal commented Oct 27, 2023

For privacy/security I allowlist sites to enable JavaScript. When I visited the site, I got a blank white page with no information.
@9glenda
Copy link

9glenda commented Oct 28, 2023

I think a warning stating to enable js would be enough.

@toastal
Copy link
Author

toastal commented Oct 28, 2023

Personally, I’d prefer at least the name of the application & a short description of what it does (usually there is a meta description for this anyhow).

If just says “Please enable JavaScript”, my response would be: for what? What will I get to see when I enable it?

@9glenda
Copy link

9glenda commented Oct 28, 2023

Personally, I’d prefer at least the name of the application & a short description of what it does (usually there is a meta description for this anyhow).

If just says “Please enable JavaScript”, my response would be: for what? What will I get to see when I enable it?

You're right.

I should clarify my point: I think the website doesn't have to work without javascript and just inform the user.

@domenkozar
Copy link
Member

There are currently no plans to support non-javascript clients.

@toastal
Copy link
Author

toastal commented Oct 30, 2023

No JS would be ideal for this sort of thing IMO, but that’s this project’s call to make.

However, the bare minimum of a <noscript> with some message should be added.

@domenkozar
Copy link
Member

domenkozar commented Oct 30, 2023 via email

@toastal
Copy link
Author

toastal commented Oct 31, 2023 •
edited
Loading

I don’t understand the code base with no HTML files & mustache files that aren’t obvious to me. But would expect something along the lines of:

<html lang="en">
	<head>
		<title>Flakestry<!-- This is missing; it confusingly says “Elm Land” --></title>
		<meta name="description" content="A place to find, install, and publish Nix Flakes">
	<body>
		<noscript>
			<article class="AddWrapperClassHere ScriptBlockersWon’tUseClassFromNoscriptElement">
				<header>
					<h1>Flakestry<h1>
					<p>Find, Install, &amp; Publish <a href="https://nix.dev/concepts/flakes/">Nix Flakes</a>.</p>
				</header>
				<section>
					<p>
						The Flakestry service requires JavaScript to be enabled.
						<a href="https://www.enable-javascript.com/en/">See these instructions</a> on how to enable in your browser.
						Alternatively, you may need to add an exception to your script blocker.
					</p>
				</section>
			</article>
		</noscript>

@vhsconnect vhsconnect linked a pull request Dec 12, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

devenv: inject <noscript-tag> after build vhsconnect/flakestry.dev
3 participants
@domenkozar @toastal @9glenda