Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flameshot not working on Plasma Wayland #2660

Closed
DemonicSavage opened this issue Jun 12, 2022 · 21 comments
Closed

Flameshot not working on Plasma Wayland #2660

DemonicSavage opened this issue Jun 12, 2022 · 21 comments
Labels
Bug It's a bug Wayland Wayland specific issues
Milestone

Comments

@DemonicSavage
Copy link

DemonicSavage commented Jun 12, 2022

Flameshot Version

Flameshot v11.0.0 (-)
Compiled with Qt 5.15.3

Installation Type

Flatpak from Flathub

Operating System type and version

Arch Linux

Description

When I open Flameshot and click on "Take Screenshot" in the system tray icon, nothing happens.
"Open Launcher" opens the launcher, but "Take new screenshot" does nothing.

Steps to reproduce

  1. Run Flameshot
  2. Click on "Take Screenshot" on system tray icon

Screenshots or screen recordings

No response

System Information

System:
  Host: Belphegor Kernel: 5.18.3-zen1-1-zen arch: x86_64 bits: 64
    Desktop: KDE Plasma v: 5.24.5 Distro: Arch Linux
Graphics:
  Device-1: AMD Navi 23 [Radeon RX 6600/6600 XT/6600M] driver: amdgpu
    v: kernel
  Device-2: Generalplus GENERAL WEBCAM type: USB
    driver: snd-usb-audio,uvcvideo
  Display: wayland server: X.org v: 1.21.1.3 with: Xwayland v: 22.1.2
    compositor: kwin_wayland driver: X: loaded: amdgpu unloaded: modesetting
    gpu: amdgpu resolution: 1: 1920x1080 2: 1920x1080
  OpenGL: renderer: AMD Radeon RX 6600 XT (dimgrey_cavefish LLVM 13.0.1 DRM
    3.46 5.18.3-zen1-1-zen)
    v: 4.6 Mesa 22.1.1

Both xdg-desktop-portal and xdg-desktop-portal-kde are installed.

@DemonicSavage DemonicSavage added the Unconfirmed Bug The bug is not confirmed by anyone else. label Jun 12, 2022
@LennyPenny
Copy link

LennyPenny commented Jun 12, 2022

I can confirm the same problem on the fedora 36 KDE spin. (installed from normal fedora sources)

~ 7.5s ❱ flameshot --version
Flameshot v11.0.0 (-)
Compiled with Qt **5.15.2**
OS: Fedora release 36 (Thirty Six) x86_64
Kernel: 5.17.13-300.fc36.x86_64
DE: Plasma 5.24.5

@mmahmoudian mmahmoudian self-assigned this Jun 12, 2022
@cprpolo
Copy link

cprpolo commented Jun 14, 2022

Same thing happening in Manjaro Wayland:

flameshot -v Flameshot v11.0.0 (-) Compiled with Qt 5.15.3

OS: Manjaro Linux x86_64 Kernel: 5.17.14-1-MANJARO DE: Plasma 5.24.5

@mmahmoudian
Copy link
Member

I can confirm this issue in a clean install Fedora 36 Wayland KDE in VM and installed Flameshot v11.0.0 using sudo dnf install flameshot.

As explained, when left-clicking on Flameshot tray icon "nothing happens" (i.e no error or notification). The same with when I right-click on the tray icon and click Take Screenshot".

When I kill Flameshot and run flameshot gui, I get the following:

image

@mmahmoudian mmahmoudian removed their assignment Jun 14, 2022
@mmahmoudian mmahmoudian added Bug It's a bug Wayland Wayland specific issues and removed Unconfirmed Bug The bug is not confirmed by anyone else. labels Jun 14, 2022
@borgmanJeremy
Copy link
Contributor

borgmanJeremy commented Jun 14, 2022

@mmahmoudian If i build from source this is not an issue so I suspect we have already resolved this. Please follow the steps below. It's a little strange on KDE wayland because of the way the security works (you need to copy the binary to match the path in the .desktop file)

Assuming you already have the portal dependencies installed

dnf install flameshot # Hack to install runtime files
dnf install kf5-kguiaddons-devel # Required for wayland clipboard on KDE


git clone https://github.com/flameshot-org/flameshot
cd flameshot
mkdir build
cd build
cmake -GNinja -DUSE_WAYLAND_CLIPBOARD=True ../
ninja
sudo cp ./src/flameshot /usr/bin/flameshot

@mmahmoudian
Copy link
Member

mmahmoudian commented Jun 14, 2022

@borgmanJeremy
if kf5-kguiaddons-devel (in Arch kguiaddons) is always required in wayland, should we add it as dependency?

If i build from source this is not an issue

I can confirm that, although I had to install qt5-qtsvg-devel as a dependency for compiling as well.

btw, while testing it, I realized that one of out SVGs are not rendered properly (the orange is my bare-metal install and the purple is the VM):

image

@borgmanJeremy
Copy link
Contributor

if kf5-kguiaddons-devel (in Arch kguiaddons) is always required in wayland, should we add it as dependency?

It's only required for KDE so I do not have a good answer. If a user has a gnome only desktop I was worried the kf5 tools would pull in a bunch of unused dependencies.

btw, while testing it, I realized that one of out SVGs are not rendered properly (the orange is my bare-metal install and the purple is the VM):

Okay, ill roll back that SVG and can you open a new issue?

@mmahmoudian
Copy link
Member

@borgmanJeremy Done: #2667

@LennyPenny
Copy link

LennyPenny commented Jun 15, 2022

@borgmanJeremy this issue is not for tracking the SVG thing, please reopen

@borgmanJeremy
Copy link
Contributor

This is resolved on the master branch. I tested on fedora 36

@LennyPenny
Copy link

What about this optional dependency that is required for plasma? If its not included then its not really
resolved I guess

@borgmanJeremy
Copy link
Contributor

That's not a flameshot issue, that's something that needs to be resolved with your distribution

@Victor239
Copy link

@borgmanJeremy this issue is regarding the Flatpak. There should be no additional distro-specific packages that need to be installed, otherwise what's the point of Flatpak?

@borgmanJeremy
Copy link
Contributor

Ah I was testing the RPM. Let me see if the latest flatpak works.

@borgmanJeremy
Copy link
Contributor

I tested the latest flatpak from our CI and it is working on Fedora 36 KDE. I'll have the version 12 beta out today or tomorrow so if you want to wait to test that I would appreciate it.

@DemonicSavage
Copy link
Author

Is the issue where it only works on one screen already known, or should I file another bug report?

@Victor239
Copy link

@borgmanJeremy thanks, will that be on Flathub Beta channel or the normal Flathub? Also could you reopen this issue?

@DemonicSavage #2364

@borgmanJeremy
Copy link
Contributor

It's available our release page. It will go in flathub when it's out of beta.

@mmahmoudian
Copy link
Member

@Victor239

Also could you reopen this issue?

Sure, but considering the sheer volume of issues we should keep track of, please remind me to close this issue when/if it was resolved.

@mmahmoudian mmahmoudian reopened this Jun 17, 2022
@mmahmoudian mmahmoudian added this to the v12 milestone Jun 17, 2022
@Victor239
Copy link

Thanks the new release beta works, clicking on the system tray icon lets me take a screenshot again. I've run into #2364 now though, but this other issue is resolved for me.

@SpidFightFR
Copy link

i installed the flameshot-git package from the AUR, it doesn't seem to work.
The other version of the package, flameshot does work but the app works weirdly: it "casts" my main screen on the second screen and i have to capture my main screen on the second one.

It's weird.

@mmahmoudian
Copy link
Member

I just confirmed in the same VM as before that the issue is indeed resolved after sudo dnf update which updated Flameshot to 120.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug It's a bug Wayland Wayland specific issues
Projects
None yet
Development

No branches or pull requests

7 participants