Optimize various SVGs (second try) #2318
Conversation
|
I've only tested on MacOs but the circle counter looks correct now. |
|
that should be all, I think. Everything should work now. |
|
Can you squash and rebase on master? As an aside please don't have obscenities in the final commit message, I try to keep it family friendly 😁 |
wish me luck :/ git usually doesn't like me
got it! Wouldn't have added any, since that one is actually important, but in the future I'll try to keep them out of the regular ones as well 👍🏻 |
|
If git gives you a problem let me know I can fix it |
decreased file size, complexity, fixed spec compliancy and fixed one case where the text rendered weirdly sometimes
|
ayy it worked! |
|
Thanks! Just tested this on MacOS and its 99% correct. The only issue is with the "upload to imgur icon". The massive keyboard looked good too. I'll test on Windows tomorrow. |
|
should be fixed now, will test on windows later today as well |
|
tested x64 portable on windows, works without visible problems. |
|
All looks good here. Thanks!! |
|
Do you have directions for how you generated these reduced SVGs? If i make more icons in the future I can minimize them. |
If you could see the bags under my eyes you wouldn't ask that question. On a more serious note, most of it is just knowing what stuff you can remove without problems, various tricks to make paths shorter and a few handy websites: yqqn's path editor, ellipse/circle to path converter, and inkscape if there's some path transform you can't do otherwise. There's also various websites and applets that try to minimize SVGs automagically, but I haven't had much success with them in the past. TL;DR: it's mostly experience. |
|
Haha that shows my ignorance for graphic design. I usually draw it in GIMP and then auto trace it in Inkscape.... |
|
you can send me a message when you need a new icon → [email protected] |
* Optimized various SVGs decreased file size, complexity, fixed spec compliancy and fixed one case where the text rendered weirdly sometimes * fixed a single space too little 🤦
* Optimized various SVGs decreased file size, complexity, fixed spec compliancy and fixed one case where the text rendered weirdly sometimes * fixed a single space too little 🤦 (cherry picked from commit 5ab76e2)
So last time didn't work - for more context see #2130 and #2179.
I only fixed the circlecount image for now, to see if this hypothetical fix even works. If this doesn't work then your SVG engine is severely outdated or just plain shit.
Anyway, @borgmanJeremy could you please check if the circlecount image displays correctly now? Compat. commit is 038f869