Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unexpected close when launch external app #2617

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

Alaskra
Copy link
Contributor

@Alaskra Alaskra commented May 21, 2022

fix #2562

@Alaskra
Copy link
Contributor Author

Alaskra commented May 21, 2022

image
I don't understand the meaning of comment, but the code have effect to linux and cause the problem of launchapp. So I add the MACOS macro.

@Alaskra
Copy link
Contributor Author

Alaskra commented May 21, 2022

image
flameshot gui won't exit if click copy or pin button after capture because there is no window close to trigger qt's quitOnLastWindowClose(the caputrewidget set attribute Qt::WA_QuitOnClose to false for some reason I don't know, so close it don't trigger quit). So I create and close the window just to trigger quit.

@ramseyrashid
Copy link

Any way we can get this one prioritized? Thanks!

@borgmanJeremy
Copy link
Contributor

@ramseyrashid I am still thinking this over. I'm not pleased with this hack but don;t have an alternative solution yet.

src/main.cpp Show resolved Hide resolved
@borgmanJeremy borgmanJeremy merged commit fb42ad5 into flameshot-org:master Jun 10, 2022
panpuchkov pushed a commit to namecheap/flameshot that referenced this pull request Jun 12, 2022
* fix unexpected close when launch external app

* update

(cherry picked from commit fb42ad5)
@mohad12211
Copy link

is there some other alternative to this hacky solution?
opening and closing a window on a tiling window manger like dwm in my case, will mess with the size of the other windows for a moment because it tries to tile the window, it's annoying with a lot of apps, example:

Peek.2022-06-16.02-14.mp4

@borgmanJeremy
Copy link
Contributor

I was worried something strange would happen☹️

I did not think of an alternative but am open to suggestions

@Alaskra
Copy link
Contributor Author

Alaskra commented Jun 17, 2022

@mohad12211 @borgmanJeremy I remove the hack in #2675. Is this ok?

@mohad12211
Copy link

Yes, #2675 introduces no issues with the window manager, and the "launch external app" works with no problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open in external application (a.k.a App Launcher) closes immediately
4 participants