Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persistent-mac option to v6 #1946

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

manuelbuil
Copy link
Collaborator

Description

Adds the persistency of the MAC to the v6 flannel interface too

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Flannel-v6 interface gets a persistent MAC


macStr := be.subnetMgr.GetStoredMacAddress(ctx)
macStr, macStrv6 := be.subnetMgr.GetStoredMacAddresses(ctx)
log.Infof("MANU - This is macStr and this is macStrv6: %s %s", macStr, macStrv6)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MANU?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha that's my log, sorry it's not 100% ready yet because I found some extra stuff

@manuelbuil manuelbuil requested a review from rbrtbnfgl April 17, 2024 10:01
@kyrofa
Copy link

kyrofa commented Apr 17, 2024

Thank you for this!

@manuelbuil manuelbuil merged commit d323333 into flannel-io:master Apr 18, 2024
8 checks passed
@manuelbuil manuelbuil deleted the addpersistentmacv6 branch April 18, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants