-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cgroupv1: do not run tests for version >= 4179 #569
Conversation
Thanks, this can be done on the kubeadm test too: mantle/kola/tests/kubeadm/kubeadm.go Lines 148 to 166 in 28a2bfa
|
Yes, that needs to be addressed, but do not know where is the best place to compare with a max version aka EndVersion. I think it should be done in a unified way, only defined once and used accordingly. |
dda563c
to
8f9cec9
Compare
8f9cec9
to
6642c50
Compare
Hello @flatcar/flatcar-maintainers, I would like to have this PR reviewed, to unblock flatcar/scripts#2145 |
kola/tests/misc/cgroup1.go
Outdated
@@ -38,6 +38,7 @@ func init() { | |||
}, | |||
Distros: []string{"cl"}, | |||
MinVersion: semver.Version{Major: 3033}, | |||
EndVersion: semver.Version{Major: 4152}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the next alpha will be greater than 4152. So we might need to bump this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depends on when we merge the systemd PR. now (aka today), or after the next alpha gets released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that the next alpha release will be 4179, let's get this merged after this next alpha release to have time for better functional testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to 4179 for ample of time.
6642c50
to
7463baf
Compare
Flatcar with systemd >= 256 does not support cgroupv1 anymore.
See: flatcar/scripts#2145