Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal frontend updates, drop support for old node versions (12.x, 14.x), new Ubuntu LTS on CI #647

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Minimal frontend updates, drop support for old node versions (12.x, 14.x), new Ubuntu LTS on CI #647

merged 3 commits into from
Mar 27, 2023

Conversation

illume
Copy link
Contributor

@illume illume commented Mar 27, 2023 •
edited
Loading

Some frontend updates

More updates could be done, but they would take longer and require more intensive testing. This would be an intermediate update of frontend dependencies.

  • Drop node 12.x, and 14.x support to ease maintenance. Node 16+ supports the new lockfile version 2/3. Supporting node 14.x would be possible but would harder to keep dependencies up to date since much of the ecosystem has moved on.
  • Npm audit fix was run. Some vulnerabilities remain listed, but less than before. From "79 vulnerabilities (3 low, 6 moderate, 55 high, 15 critical)" to "51 vulnerabilities (1 low, 1 moderate, 40 high, 9 critical)".
  • Supporting node 18 requires either using an old openssl or upgrading some packages. Upgrading webpack via react-scripts update would be a larger upgrade requiring more changes. In order to reduce the amount of changes in this release and reduce the time required for testing. Node 18 isn't supported so far. Continuing to not support it is not a regression. Not supporting node 18 seems to be the better of the options for now, with future upgrades to support node 18 with more extensive changes.

How to use

It should work as before.

Testing done

  • locally confirmed tests pass
  • ci passes

vbatts and others added 3 commits March 27, 2023 08:34
@vbatts @illume
github: Update ubuntu to LTS and drop older nodejs versions
22f49f7 
Drop node 14.x support because it does not support modern
package-lock.json lockfile versions. Node 16, and 18 support the
latest version 3.

Supporting node 14.x is too much maint work for not much gain.

18.x has an incompatibility with the webpackge build tool
currently used by react-scripts we are using. So for now
do not upgrade to use that version of node.

Signed-off-by: Vincent Batts <[email protected]>
@illume
frontend: Update package-lock with only npm install
cd58b37 
Using node 16.x, this uses a more modern package-lock.json format.
@illume
frontend: Update dependencies with npm audit fix
93f43b9
@illume illume changed the title wip: frontend updates Minimal frontend updates, drop support for old node version, new Ubuntu LTS on CI Mar 27, 2023
@illume illume changed the title Minimal frontend updates, drop support for old node version, new Ubuntu LTS on CI Minimal frontend updates, drop support for old node versions (12.x, 14.x), new Ubuntu LTS on CI Mar 27, 2023
@illume illume requested a review from yolossn March 27, 2023 08:03
@illume illume marked this pull request as ready for review March 27, 2023 08:03
@illume illume requested a review from vbatts March 27, 2023 08:05
yolossn
yolossn approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@yolossn yolossn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly taking a look into this.

@yolossn yolossn merged commit 3f95eeb into main Mar 27, 2023
@yolossn yolossn mentioned this pull request Mar 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yolossn yolossn yolossn approved these changes

@vbatts vbatts Awaiting requested review from vbatts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illume @yolossn @vbatts