Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initrd_size_decrease: remove mlxsw_spectrum/mlxsw_core kernel modules #1734

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

ader1990
Copy link
Contributor

@ader1990 ader1990 commented Mar 6, 2024

This commit is part of the effort to decrease the initrd size: Partially-Fixes: flatcar/Flatcar#1381

mlxsw_spectrum/mlxsw_core are kernel modules that enable Mellanox Technologies Switch ASICs support.
Removing the two modules frees ~5MB in the /boot partition and ~4MB in the vmlinuz.
/dev/vda1 129039 59962 69078 47% /boot with the removal on AMD64.

See discussion: #1731 (comment)

Copy link

github-actions bot commented Mar 6, 2024

@ader1990 ader1990 marked this pull request as ready for review March 11, 2024 11:35
@jepio
Copy link
Member

jepio commented Mar 12, 2024

@ader1990 can you add a changelog entry?

@ader1990 ader1990 force-pushed the ader1990/decrease_initrd_size_v1 branch from 0ece7b1 to 381bac3 Compare March 12, 2024 15:01
@ader1990
Copy link
Contributor Author

@ader1990 can you add a changelog entry?

added.

@ader1990 ader1990 requested review from pothos and jepio March 12, 2024 16:33
@jepio
Copy link
Member

jepio commented Mar 12, 2024

Can you follow the example of other changelog entries and add a link to the PR? That way it's cross referenced and people can discover the motivation for a change (here: "reducing the size of the initrd").

@jepio
Copy link
Member

jepio commented Mar 12, 2024

And then feel free to merge directly since Kai already gave his approval.

This commit is part of the effort to decrease the initrd size:
Partially-Fixes: flatcar/Flatcar#1381

Signed-off-by: Adrian Vladu <[email protected]>
@ader1990 ader1990 force-pushed the ader1990/decrease_initrd_size_v1 branch from 381bac3 to 3da9f85 Compare March 12, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Flatcar boot partition size shrink effort
3 participants