Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid uninitialized instance variable warning #268

Merged
merged 1 commit into from
May 15, 2023

Conversation

dharamgollapudi
Copy link
Contributor

Addresses the following ruby warning

gems/2.7.0/gems/loofah-2.21.2/lib/loofah.rb:10: warning: instance variable @html5_support_set not initialized

which is more of a noise than signal.

@flavorjones
Copy link
Owner

Thank you for submitting this PR! I had forgotten that Ruby <= 2.7 still warns about uninitialized instance variables (Ruby 3.0 and later does not).

@flavorjones
Copy link
Owner

I've cleaned up the commit (which was failing rubocop checks) and reworded the commit message. Thank you for this contribution!

@flavorjones flavorjones merged commit 5c4a567 into flavorjones:main May 15, 2023
@flavorjones flavorjones changed the title Update loofah.rb avoid uninitialized instance variable warning May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants