Add encoding arg to DocumentFragment#parse to mimic Nokogiri #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
added a commit
that referenced
this pull request
Apr 23, 2014
Add encoding arg to DocumentFragment#parse to mimic Nokogiri
|
Merged, thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the comments on
Loofah.fragment, it accepts the same parameters asNokogiri::HTML::DocumentFragment.parse. I'm sure this was probably true at original time of writing but it is no longer true, due to the fact thatNokogiri::HTML::DocumentFragment.parsenow accepts anencodingargument, which is used to set the encoding of the parent Document for the DocumentFragment (or defaults to'UTF-8'if nothing is fed in). This pull adds thatencodingargument toLoofah::HTML::DocumentFragment, and makes it mimic the functionality of theparsemethod forLoofah::HTML::DocumentFragment.parse.