Allow multi-word data attributes #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,7 +23,7 @@ def scrub_attributes node | |||
| attr_node.node_name | |||
| end | |||
|
|
|||
| if attr_name =~ /\Adata-\w+\z/ | |||
| if attr_name =~ /\Adata-[\w-]+\z/ | |||
There was a problem hiding this comment.
Maybe we should make this configurable so people can for example disallow data attributes.
flavorjones
added a commit
that referenced
this pull request
May 5, 2015
Allow multi-word data attributes
|
Awesome, thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of #59. It's very common when using data attributes to have a multi-word name like
data-user-emailordata-shop-id. However, the regex added in #59 wasn't general enough to allow these multi-word attributes so they are being scrubbed by the default scrubbers whereas single-word names likedata-userare being passed over.Sidenote: I double-checked the spec and separating words with dashes is definitely the correct way to be doing this
http://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes
@flavorjones cc @rafaelfranca