Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables UI: make clickable row behavior consistent #24766

Open
27 tasks
eugkuo opened this issue Dec 13, 2024 · 7 comments
Open
27 tasks

Tables UI: make clickable row behavior consistent #24766

eugkuo opened this issue Dec 13, 2024 · 7 comments
Assignees
Labels
~frontend Frontend-related issue. #g-software Software product group :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature

Comments

@eugkuo
Copy link
Contributor

eugkuo commented Dec 13, 2024

Goal

User story
As a user of the platform,
I want to experience the UI of tables consistently
so that I can easily understand what the interactions will do..

Key result

Every sprint ship small UX improvements based on dogfooding or customer experience.

Original requests

None.

Context

Changes

Product

  • UI changes:
    • Hosts

      • Clicking anywhere in a table row should open the detail screen.
    • Controls//OS updates

      • On table rollover, should read “View all hosts” before the right-chevron
      • ‘View all hosts’ link should underline when rolling over the ‘Hosts’ cell
    • Controls/Scripts

      • Add grey highlight behavior rollover of table rows.
    • Software/Software

      • Version, Type, and Vulerabilities cells should click to the detail screen.
      • ‘View all hosts’ link should underline when rolling over the ‘Hosts’ cell
    • Software/OS

      • Version and Vulnerabilities cells should click to the detail screen.
      • ‘View all hosts’ link should underline when rolling over the ‘Hosts’ cell
    • Software/Vulnerabilities

      • Severity, Probability of exploit, Published, and Detected cells should click to the detail screen.
      • ‘View all hosts’ link should underline when rolling over the ‘Hosts’ cell
    • Queries

      • Clicking on any cell should open the detail screen (save for the checkbox cell)
  • CLI (fleetctl) usage changes: No changes
  • YAML changes: No changes
  • REST API changes: No changes
  • Fleet's agent (fleetd) changes: No changes
  • Activity changes: No changes
  • Permissions changes: No changes
  • Changes to paid features or tiers: No changes
  • Other reference documentation changes: No changes
  • Once shipped, requester has been notified
  • Once shipped, dogfooding issue has been filed

Engineering

  • Feature guide changes: N/A
  • Database schema migrations: N/A
  • Load testing: N/A

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

  • Requires load testing: No
  • Risk level: Low

Manual testing steps

UI changes:

  • On /hosts/manage, clicking anywhere in a table row should open the host detail screen.
  • On /controls/os-updates, on table rollover, should read “View all hosts” before the right-chevron
  • On /controls/os-updates, ‘View all hosts’ link should underline when rolling over the ‘Hosts’ cell
  • On /controls/scripts rolling over table rows should highlight the row in grey
  • On /software/titles when clicking the Version, Type, or Vulnerabilities cells, you should be taken to the Software detail screen.
  • On /software/titles the ‘View all hosts’ link should underline when rolling over the ‘Hosts’ cell
  • On /software/os when clicking the Version or Vulnerabilities cells, you should be taken to the OS detail screen.
  • On /software/os the ‘View all hosts’ link should underline when rolling over the ‘Hosts’ cell
  • On software/vulnerabilities when clicking the Severity, Probability of exploit, Published, and Detected cells you should be taken to the Vulnerability detail screen.
  • On software/vulnerabilities the ‘View all hosts’ link should underline when rolling over the ‘Hosts’ cell
  • On /queries/manage when clicking Targeted platforms, Frequency, Performance impact, Automations, Last modified cells you should be taken to the Query detail screen

Testing notes

Confirmation

  1. Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. QA (@____): Added comment to user story confirming successful completion of QA.
@eugkuo
Copy link
Contributor Author

eugkuo commented Dec 13, 2024

This ticket supercedes #24445

@noahtalerman
Copy link
Member

Hey @eugkuo, thanks for tracking this!

Can you please update this issue to a user story (using the user story template) and bring it to tomorrow's design review? I think we can get this one ready for Endpoint ops estimation call on Weds.

@eugkuo
Copy link
Contributor Author

eugkuo commented Dec 17, 2024

@noahtalerman

Template updated

@noahtalerman noahtalerman added the story A user story defining an entire feature label Dec 17, 2024
@noahtalerman noahtalerman added the #g-endpoint-ops Endpoint ops product group label Dec 17, 2024
@eugkuo eugkuo assigned sharon-fdm and unassigned eugkuo Dec 18, 2024
@noahtalerman noahtalerman changed the title Normalize table behaviour across the platform / update click targets Tables UI: make clickable row behavior consistent Dec 19, 2024
@noahtalerman noahtalerman added #g-orchestration Orchestration product group and removed #g-endpoint-ops Endpoint ops product group labels Dec 19, 2024
@noahtalerman noahtalerman added #g-mdm MDM product group #g-software Software product group and removed #g-orchestration Orchestration product group #g-mdm MDM product group labels Dec 19, 2024
@RachelElysia RachelElysia added the ~frontend Frontend-related issue. label Dec 20, 2024
@noahtalerman
Copy link
Member

@mostlikelee just giving you a reminder that this user story is ready for specs 🚀 Please work with @eugkuo to get this one ready for estimation.

@noahtalerman
Copy link
Member

@mostlikelee reminder that this one is ready to spec. Can you please complete the "TODOs" in the "Engineering" section so we can estimate this one?

@mostlikelee
Copy link
Contributor

Hosts
Clicking anywhere in a table row should open the detail screen.

@eugkuo what if i want to doubleclick on information (IP address) to copy it? will it send me to the details page?

@eugkuo
Copy link
Contributor Author

eugkuo commented Jan 8, 2025

@eugkuo what if i want to doubleclick on information (IP address) to copy it? will it send me to the details page?

@mostlikelee Yes. Currently, clicking on a row takes you to another page already so you can't actually doubleclick on the information to copy it, anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
~frontend Frontend-related issue. #g-software Software product group :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature
Development

No branches or pull requests

7 participants