Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1052
Test Code:
The main issue is resolved:
slider.value
now prints100
(themax
)Important Note:
As seen above the
__repr__
or even__str__
still hasvalue=150
.This is because the
self.__attrs
(where the props are stored) is not updated.This could be solved by adding
self.value = v
(resetting the value / updating theself.__attrs
) when verifying the limits in thevalue @property
as follows:but because we are in the
@property
, it will only be applied whenslider.value
is called.Let me have your thoughts on the importance of this.