Fix issues with *Buttons
#3582
Merged
Fix issues with *Buttons
#3582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request addresses issues with various button components by adding new properties, refactoring existing methods, and ensuring compatibility with both 'ThemeVisualDensity' and 'VisualDensity' enums. Key changes include updates to button style parsing, handling of disabled states, and assertions for minimum content requirements. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ndonkoHenri - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| if any([self.__color, self.__bgcolor, self.__elevation]): | ||
| self.__style = self.__style or ButtonStyle() | ||
| if self.__style: | ||
| self.__style.color = ( |
There was a problem hiding this comment.
issue (code-quality): Extract code out into method (extract-method)
FeodorFitsner
approved these changes
Jul 5, 2024
zrr1999
pushed a commit
to zrr1999/flet
that referenced
this pull request
Jul 17, 2024
* BorderSide: add stroke_align prop * proper styling in buttons * deprecate ThemeVisualDensity in favor of VisualDensity * ButtonStyle: new props * deprecation: disabled_color is renamed to disabled_bgcolor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3573
ThemeVisualDensityin favor ofVisualDensitySummary by Sourcery
This pull request addresses multiple issues with button components by adding new style properties, fixing color and elevation handling when disabled, and refactoring code for better readability and consistency. It also introduces new enums for visual density settings and ensures proper handling of deprecated enums.