-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window fullscreen on mobile devices and web #3620
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request adds fullscreen functionality for mobile devices and web. It introduces the 'fullscreen_window' package and updates the windowFullScreen logic to use 'FullScreenWindow.setFullScreen' for non-desktop platforms. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bl1nch - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Please always make sure to fill the PR template, when you open a PR. |
This PR should provide fullscreen mode for Android, IOS and WEB platforms. On Android and IOS, if fullscreen mode is active, the system status bar is hidden; on WEB, the tab simply goes into fullscreen mode |
Thanks for your PR. |
I've created upstream issue: jakky1/fullscreen_window#4 |
Need investigating. On web it enters into fullscreen mode and then immediately exits. |
Same on Android. But the default example at https://pub.dev/packages/fullscreen_window#example works fine |
Summary by Sourcery
This pull request introduces fullscreen mode support for mobile devices and web by integrating the fullscreen_window package. It updates the fullscreen logic to conditionally use this package for non-desktop platforms and adds the necessary dependency to the pubspec.yaml file.