Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] The windows CI doesn't include octomap #442

Open
SeanCurtis-TRI opened this issue Feb 7, 2020 · 3 comments
Open

[CI] The windows CI doesn't include octomap #442

SeanCurtis-TRI opened this issue Feb 7, 2020 · 3 comments

Comments

@SeanCurtis-TRI
Copy link
Contributor

In the configuration for the windows CI under appveyor, octomap functionality is not included. The CI configuration is responsible for pulling libccd and eigen, but not octomap. We should strongly consider including it, or putting a clear warning that this doesn't happen and there is no guarantees as to the windows support being consistent.

Currently, the appveyor CI process is painfully slow. There isn't much parallelism and the hardware dedicated to the process renders each test painfully long. Adding octomap support will increase the cost of each test (decreasing the CI throughput). This might be the primary reason why we would decide to not include it in CI.

@traversaro
Copy link
Contributor

Currently, the appveyor CI process is painfully slow. There isn't much parallelism and the hardware dedicated to the process renders each test painfully long. Adding octomap support will increase the cost of each test (decreasing the CI throughput). This might be the primary reason why we would decide to not include it in CI.

Switching to GitHub Actions-based Windows CI in my experienced solved many of these problems, so if you are interested I would be happy to open a PR adding CI on Windows with vcpkg-provided dependencies (including octomap) using GitHub Actions.

@SeanCurtis-TRI
Copy link
Contributor Author

I"m game. I know nothing about it and would relish the chance to learn more. It would be a greatly appreciated contribution.

@jamiesnape
Copy link
Contributor

I have a branch (among many) with new CI for Windows. They have just been waiting for the releases to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants