Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blogspot domains as tld's #3

Closed
TheHodge opened this issue Aug 29, 2013 · 5 comments
Closed

blogspot domains as tld's #3

TheHodge opened this issue Aug 29, 2013 · 5 comments

Comments

@TheHodge
Copy link

When I try to parse a domain with blogspot it gives me the blogspot url as a tld (this also happens with amazonaws sometimes.

irb(main):015:0> url = 'http://fwefweewf.blogspot.com'
=> "http://fwefweewf.blogspot.com"
irb(main):016:0> @uri = Addressable::URI.parse(url)
=> #<Addressable::URI:0x3fcd6d92e828 URI:http://fwefweewf.blogspot.com>
irb(main):017:0> @uri.tld
=> "blogspot.com"

Hope you can debug this :)

@flipsasser
Copy link
Owner

Huh. Weird. Taking a look now!

@flipsasser
Copy link
Owner

So this is kinda crazy. Apparently blogspot and the AWS domains are in the Mozilla TLD list that Addressabler uses to parse TLDs (see here: http://mxr.mozilla.org/mozilla-central/source/netwerk/dns/effective_tld_names.dat?raw=1).

I'm going to add a configuration to turn non-ICANN domains ON but leave them OFF by default. My guess is that 99% of the people using Addressabler prefer blogspot.com's TLD to be "com" regardless of what Google wants us to think.

@flipsasser
Copy link
Owner

Okay, fixed! Thanks for pointing this out.

7eb9b00

@flipsasser
Copy link
Owner

Lulz. Wrong commit. This one: c532029

@healthtools
Copy link

Thanks it was useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants