Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundle the LICENSE file in the gem #444

Merged
merged 1 commit into from
Aug 14, 2020
Merged

bundle the LICENSE file in the gem #444

merged 1 commit into from
Aug 14, 2020

Conversation

jfeltesse-mdsol
Copy link
Contributor

From https://guides.rubygems.org/specification-reference/#license=

(...) The full text of the license should be inside of the gem (at the top level) when you build it.

Oddly enough, json_pure.gemspec does include the file but not the others.

Also, json-java.gemspec called licenses= twice.

@hsbt hsbt merged commit ef00f58 into ruby:master Aug 14, 2020
@hsbt
Copy link
Member

hsbt commented Aug 14, 2020

Thanks.

@jfeltesse-mdsol jfeltesse-mdsol deleted the fix/license branch August 14, 2020 05:22
This was referenced Mar 8, 2021
Merged
Closed
Open
Open
Open
Open
Open
Open
Open
Closed
Closed
Open
This was referenced Mar 15, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Closed
Open
Closed
Open
Open
This was referenced Mar 17, 2021
Open
Open
Closed
Merged
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfeltesse-mdsol @hsbt