Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node8 ? #11

Closed
JBustin opened this issue Nov 2, 2017 · 3 comments
Closed

Support node8 ? #11

JBustin opened this issue Nov 2, 2017 · 3 comments

Comments

@JBustin
Copy link

JBustin commented Nov 2, 2017

#10 Hi,

I try my application with node8 (from v6.11.1 to v8.9.0).
When i require the module const RedisStore = require('passwordless-redisstore'), i've got this error :

Error: Module version mismatch. Expected 48, got 57.
    at Error (native)
    at Object.Module._extensions..node (module.js:597:18)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at bindings (/Users/me/myWorkspace/myOrga/myApp/node_modules/bindings/bindings.js:76:44)
   at Object.<anonymous> (/Users/me/myWorkspace/myOrga/myApp/node_modules/bcrypt/bcrypt.js:3:35)
...

It seems that node v8.9.0 (LTS) is not supported by bcrypt.

Maybe, this : kelektiv/node.bcrypt.js#513

Should it be better to use bcryptjs to avoid this kind of issue ? https://github.com/dcodeIO/bcrypt.js

Thks

@JBustin JBustin changed the title Support node8 Support node8 ? Nov 2, 2017
@JBustin
Copy link
Author

JBustin commented Nov 8, 2017

@JBustin JBustin closed this as completed Nov 8, 2017
@recrsn
Copy link

recrsn commented Nov 22, 2017

@JBustin. If you update node, you must recompile your native addons. NodeJS v8+ are fully supported by bcrypt.

npm rebuild bcrypt

This should do the task.

@JBustin
Copy link
Author

JBustin commented Nov 24, 2017

@agathver it was a problem with pm2 + yarn + nvm, and a curious manage of natives libraries.
Totally clean of pm2 resolves the problem.
Thks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants