-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating all aws clients #46
base: main
Are you sure you want to change the base?
Conversation
I've some time later this evening to look at it again |
Also, what about versioning? |
Added s3 request presigner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
I tested your PR for the mq & rds clients. The build miss the commonjs build. After fix this, my project is working well 👍
This idea is very attractive, however I would prefer to keep the aws client as peerDep and sync the version of all |
Co-authored-by: Arthur Weber <[email protected]>
Co-authored-by: Arthur Weber <[email protected]>
Ok, let's use the effect-aws version for the generated aws-client packages. Should we bump the release to 2.0? (and how to do this in this project, i don't really know). Mayor version bump because it could be breaking, because the generated Effect tagged Errors/Exceptions changed name to be in line with the smithy models |
Who can help with the projen and github workflow, so it becomes publishable? I don't have any experience with projen... |
I think this PR is too huge. Let's ship it in smaller pieces. |
Solves #44
Generates all clients in ./generated folder for a particular version of aws (e.g. v3.535.0).
I'm reusing the previous codegen-client.ts, but using the smithy files a little bit different.
It's not done yet, some open points: