Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating all aws clients #46

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Conversation

joepjoosten
Copy link

@joepjoosten joepjoosten commented Mar 17, 2024

Solves #44

Generates all clients in ./generated folder for a particular version of aws (e.g. v3.535.0).

I'm reusing the previous codegen-client.ts, but using the smithy files a little bit different.

It's not done yet, some open points:

  • I saw an implementation of presigned urls in the s3 client. Is it possible to make this more general? Can all commands be presigned?
  • How to publish?

@joepjoosten
Copy link
Author

I've some time later this evening to look at it again

@joepjoosten
Copy link
Author

Also, what about versioning?
Probably better to keep it close to the AWS clients version, but how to indicate that we created a new version of the generated code?

Copy link
Contributor

@godu godu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I tested your PR for the mq & rds clients. The build miss the commonjs build. After fix this, my project is working well 👍

scripts/codegen-clients.ts Outdated Show resolved Hide resolved
scripts/codegen-clients.ts Outdated Show resolved Hide resolved
@godu
Copy link
Contributor

godu commented Mar 19, 2024

Also, what about versioning? Probably better to keep it close to the AWS clients version, but how to indicate that we created a new version of the generated code?

This idea is very attractive, however I would prefer to keep the aws client as peerDep and sync the version of all @effect-aws/client-*. It can be more flexible if we make radical changes.

@joepjoosten
Copy link
Author

Also, what about versioning? Probably better to keep it close to the AWS clients version, but how to indicate that we created a new version of the generated code?

This idea is very attractive, however I would prefer to keep the aws client as peerDep and sync the version of all @effect-aws/client-*. It can be more flexible if we make radical changes.

Ok, let's use the effect-aws version for the generated aws-client packages. Should we bump the release to 2.0? (and how to do this in this project, i don't really know).

Mayor version bump because it could be breaking, because the generated Effect tagged Errors/Exceptions changed name to be in line with the smithy models

@joepjoosten
Copy link
Author

Who can help with the projen and github workflow, so it becomes publishable? I don't have any experience with projen...

@godu
Copy link
Contributor

godu commented Apr 18, 2024

I think this PR is too huge. Let's ship it in smaller pieces.
I took some of your improvements of codegen script in my PR #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants