-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core-distributor)!: add cuid cache #2381
Conversation
@@ -95,6 +96,8 @@ pub struct PersistentCoreDistributorState { | |||
pub unit_id_mapping: Vec<(PhysicalCoreId, CUID)>, | |||
#[serde_as(as = "Vec<(Hex, _)>")] | |||
pub work_type_mapping: Vec<(CUID, WorkType)>, | |||
#[serde_as(as = "Vec<(Hex, _)>")] | |||
pub cpu_cache: Map<CUID, PhysicalCoreId>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you need to persist a cache to disk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, but it can be better in case of restarts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I right that providers will need to cleanup cache to update Nox in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need to cleanup at least the core distributor state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Description
Allows to cache assignment by cuid for the core distributor.
Motivation
physical_core_id stability is critical for the CCP
Proposed Changes
Added cache for cuid->physical_core_id
Checklist
Reviewer Checklist