Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for exceptions assertions #31

Closed
Meir017 opened this issue Apr 17, 2018 · 3 comments · Fixed by #40
Closed

support for exceptions assertions #31

Meir017 opened this issue Apr 17, 2018 · 3 comments · Fixed by #40
Labels
enhancement

Comments

@Meir017
Copy link
Member

Meir017 commented Apr 17, 2018 •
edited
Loading

https://fluentassertions.com/tips/#exceptions
@Meir017 Meir017 mentioned this issue Jun 6, 2018
Merged
@Meir017
Copy link
Member Author

Meir017 commented Jun 21, 2018

@jnyrup I was thinking of adding cases for

  • ...Message.Should().Be("errorCode1"); => .WithMessage("errorCode1");
  • ...Message.Should().StartWith("errorCode1"); => ...WithMessage("errorCode1*");
  • ...Message.Should().EndWith("errorCode1"); => ...WithMessage("*errorCode1");

does this make sense?

@jnyrup
Copy link
Member

jnyrup commented Jun 21, 2018

I think it makes perfect sense.
It improves the failure message a bit and is shorter to write.

Any concerns you would like a second opinion about?

@Meir017
Copy link
Member Author

Meir017 commented Jun 21, 2018

I just wanted to be sure I'm not overthinking it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Features/exceptions fluentassertions/fluentassertions.analyzers
2 participants
@jnyrup @Meir017