-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: live printing bed mesh changes #1056
feat: live printing bed mesh changes #1056
Conversation
Signed-off-by: Pedro Lamas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but are the buttons (clear profile, delete profile) enabled while printing intentionally now? Not sure what the side effects of deleting a profile while printing would be..
All good points, I've been giving some though on this for the last couple of days! Starting on delete, once a bed mesh is loaded into memory, the profile can be deleted and the mesh data will remain in memory, so deleting a profile while printing has zero impact on the active print. Now loading or clearing a profile while printing will impact the active print. I agree that a simple click as it currently is might not be appropriate... so maybe show a confirmation message for clear/load if state printing? |
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This a considerable refactor of Bed Mesh in Fluidd and will need further testing, but brings the following major changes:
printer.bed_mesh.profiles
object instead of config settings (reason being that this object is "live" updated, but the config never changes)Note: this might be easier to review with "hide whitespace" option enabled!