fix: more selective keyboard events for history navigation #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrolamas
approved these changes
May 11, 2023
pedrolamas
requested changes
May 11, 2023
There was a problem hiding this comment.
Can you please add a footer to the main PR comment with a "Signed-off-by" line, following the CONTRIBUTING guidelines.
Thank you!
Allows up/down navigation in multi-line/wrapped inputs using Ctrl modifier, and selection using the Shift modifier. Signed-off-by: Maël Kerbiriou <[email protected]>
Piezoid
force-pushed
the
console-history-keybind
branch
from
a1d90d7 to
be0f4b2
Compare
pedrolamas
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While copying text from a different virtual desktop to fluidd's console, I was annoyed that the window manager global shortcuts (Meta+Up/Down keys) triggered history navigation in the text input, erasing the current input. This is because keyup events are not captured by the windows manager, unlike keydown events.
I also added .exact filters, enabling navigation in multi-line/wrapped inputs using the Ctrl modifier, and selection using the Shift modifier.