Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pause autoscroll when back scrolling #495

Merged
merged 5 commits into from
Feb 18, 2022
Merged

feat: pause autoscroll when back scrolling #495

merged 5 commits into from
Feb 18, 2022

Conversation

randellhodges
Copy link
Contributor

When scrolled up, it will "pause" the auto scroll to bottom until you scroll down or click the button to scroll back to the bottom. The button will only be displayed when scrolling is "paused".

This is for #343

This was lightly tested with Firefox and Edge in Ubuntu. Additional testing would be appreciated.

@StuSerious StuSerious linked an issue Jan 30, 2022 that may be closed by this pull request
Pause auto-scroll automatically when scrolling up in console #343
Closed
@pedrolamas pedrolamas changed the title Pause autoscroll when back scrolling feat: pause autoscroll when back scrolling Jan 31, 2022
@pedrolamas pedrolamas added the FR - Enhancement New feature or request label Feb 3, 2022
pedrolamas
pedrolamas requested changes Feb 16, 2022
View reviewed changes
Copy link
Member

@pedrolamas pedrolamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a styling/layout issue here, as the new "scroll to bottom" button is bigger than the existing ones:

image

@pedrolamas pedrolamas added the GH - Waiting for Feedback Waiting for the issuer to reply label Feb 16, 2022
@pedrolamas
Copy link
Member

I've fixed the layout issues using the proposed solution!

@pedrolamas pedrolamas removed the GH - Waiting for Feedback Waiting for the issuer to reply label Feb 18, 2022
@matmen matmen merged commit bf353fd into fluidd-core:develop Feb 18, 2022
@randellhodges randellhodges deleted the pause-scroll branch February 19, 2022 04:05
@matmen matmen added this to the Release: 1.17 milestone Feb 22, 2022
matmen pushed a commit to matmen/fluidd that referenced this pull request Jun 27, 2022
@randellhodges @matmen
feat: pause autoscroll when back scrolling (fluidd-core#495)
49f0b06 
* Pause autoscroll when scrolled up
Signed-off-by: Randell Hodges <[email protected]>

* fix: ConsoleCard buttons layout
Co-authored-by: Pedro Lamas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matmen matmen matmen approved these changes

@pedrolamas pedrolamas pedrolamas approved these changes

Assignees
No one assigned
Labels
FR - Enhancement New feature or request
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.

Pause auto-scroll automatically when scrolling up in console
3 participants
@randellhodges @pedrolamas @matmen