Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show pressure and humidity from sensors #538

Merged

Conversation

pedrolamas
Copy link
Member

@pedrolamas pedrolamas commented Feb 24, 2022

Here's how it is currently showing the humidity output from a BME280 connected to a Pi Zero 2W running as MCU:

image

Fixes #335, fixes #397, fixes #434

Signed-off-by: Pedro Lamas [email protected]

@matmen matmen added the FR - Enhancement New feature or request label Feb 24, 2022
@matmen matmen added this to the Release: 1.18 milestone Feb 24, 2022
@pedrolamas pedrolamas force-pushed the pedrolamas/extrasensorfields branch from 3064122 to 960c70e Compare March 18, 2022 14:54
@pedrolamas pedrolamas marked this pull request as ready for review March 18, 2022 14:59
Copy link
Member

@matmen matmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test it properly because I don't have access to any of these sensors, but I did find one small issue while testing:

src/components/widgets/thermals/TemperatureTargets.vue Outdated Show resolved Hide resolved
Signed-off-by: Pedro Lamas <[email protected]>
@pedrolamas pedrolamas requested a review from matmen March 19, 2022 10:15
@pedrolamas pedrolamas merged commit 9c5e904 into fluidd-core:develop Mar 19, 2022
@pedrolamas pedrolamas deleted the pedrolamas/extrasensorfields branch March 19, 2022 10:50
matmen pushed a commit to matmen/fluidd that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
2 participants