Added thumbnail URI encoding #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernd Helm <[email protected]>
pedrolamas
reviewed
Mar 30, 2022
Improved thumbnail URL encoding Co-authored-by: Pedro Lamas <[email protected]>
matmen
approved these changes
Mar 31, 2022
pedrolamas
added a commit
that referenced
this pull request
Mar 31, 2022
This reverts commit 30efd5f.
pedrolamas
added a commit
that referenced
this pull request
Mar 31, 2022
This reverts commit 30efd5f. Signed-off-by: Pedro Lamas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that a thumbnail was not displaying when i uploaded a gcode file with "infill 10%" in its name. Turned out the thumbnail name is basically the gcode name and also contained the % character which was not url encoded. Fixed that and also for the path, as the same problem may happen there.
The gcode name was auto-generated by the cura "Gcode Filename Format Plus" plugin.