Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: graduates g-code previewer to non-beta #620

Merged
merged 2 commits into from
Mar 31, 2022

Conversation

pedrolamas
Copy link
Member

Closes #181

Signed-off-by: Pedro Lamas [email protected]

@pedrolamas pedrolamas requested a review from matmen March 30, 2022 18:32
@pedrolamas pedrolamas added the UI - QoL Improvements to the UI label Mar 30, 2022
@pedrolamas pedrolamas added this to the 1.18 milestone Mar 30, 2022
@pedrolamas pedrolamas merged commit e61cd33 into fluidd-core:develop Mar 31, 2022
@pedrolamas pedrolamas deleted the pedrolamas/gcode-preview branch March 31, 2022 08:12
@AntoszHUN
Copy link
Contributor

Hi! I've updated the Hungarian language several times, but I don't see the change in Fluidd's web interface. Why is this?

Signed-off-by: AntoszHUN [email protected]

@pedrolamas
Copy link
Member Author

Hi! I've updated the Hungarian language several times, but I don't see the change in Fluidd's web interface. Why is this?

Hi @AntoszHUN, that's because your changes are only on the develop branch and will only be available on the master branch when we release a new version.

There was a mistake today where some code got inadvertently merged to master branch, that was reverted as we are not ready to release it yet.

Can I ask that you post either on your PRs, by opening a new issue, or just come to us on Discord? Using non-related PRs is not ideal... thank you!

@AntoszHUN
Copy link
Contributor

Hi! I've updated the Hungarian language several times, but I don't see the change in Fluidd's web interface. Why is this?

Hi @AntoszHUN, that's because your changes are only on the develop branch and will only be available on the master branch when we release a new version.

There was a mistake today where some code got inadvertently merged to master branch, that was reverted as we are not ready to release it yet.

Can I ask that you post either on your PRs, by opening a new issue, or just come to us on Discord? Using non-related PRs is not ideal... thank you!

I mean so update to the next version. It's so clear. I thought the OS was just updated. But then it has nothing to do with Fluidd. How do I know if an update or a new version is coming? I have Klipper, Moonraker, KlipperScreen, and OS on my web interface. There is no fluid. How is it updated? Do I need to reinstall?

@matmen
Copy link
Member

matmen commented Mar 31, 2022

There is no fluid. How is it updated? Do I need to reinstall?

add

[update_manager client fluidd]
type: web
repo: fluidd-core/fluidd
path: ~/fluidd

to your moonraker.conf

And as Pedro already stated, please use our Discord server for support requests, not random PRs. Hope this helps.

@AntoszHUN
Copy link
Contributor

Thanks! Sorry. I don't have a Discord. I do not speak English. So there are several reasons I don’t use it. Why an extra program if it's easier to write here?

matmen pushed a commit to matmen/fluidd that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI - QoL Improvements to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCODE preview
3 participants