Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google pay displays 0 amount when confirming setupIntent #1339

Closed
DavidEcclesPH opened this issue Jul 26, 2023 · 6 comments
Closed

google pay displays 0 amount when confirming setupIntent #1339

DavidEcclesPH opened this issue Jul 26, 2023 · 6 comments
Labels
blocked This issue is blocked by an external dependency issue bug Something isn't working

Comments

@DavidEcclesPH
Copy link

Describe the bug
relates to #1250 but i'm commenting here for visibility as that issue is closed. Google pay still displays 0 amount when confirming a subscription payment via confirmSetupIntent. We noticed the branch fix-amount-google-pay #1255 did not get merged to the last release is it expected in a release in the near future?

To Reproduce
use google pay to pay for a subscription (confirm setupupintent)

Expected behavior
google pay UI shows the amount relating to the subscription, not £0

Smartphone / tablet

  • Device: multiple android devices
  • OS: > android 8.1
  • Package version: 9.3.0
  • Flutter version [e.g. 2.0.0.]
@DavidEcclesPH DavidEcclesPH added the needs triage Needs triage label Jul 26, 2023
@DavidEcclesPH
Copy link
Author

@remonh87 @jamesblasco would you be able to provide us an eta on this issue? We tried to fork the repo to merge the [fix-amount-google-pay] branch ourselves but couldn't build our project pointing to the forked repo.

@remonh87
Copy link
Member

remonh87 commented Aug 1, 2023

hey I did test it and I think we need to wait for stripe/stripe-react-native#1436. I will poke stripe to look into it

@remonh87 remonh87 added the blocked This issue is blocked by an external dependency issue label Aug 1, 2023
@remonh87
Copy link
Member

remonh87 commented Aug 1, 2023

as alternative you can maybe use createPlatformPayPaymentMethod

@remonh87 remonh87 added bug Something isn't working and removed needs triage Needs triage labels Aug 1, 2023
@DavidEcclesPH
Copy link
Author

morning @remonh87 just checking back in on this, wondering if there is any expected updates here? Not sure where the change came in but Google pay now shows no amount/description label at all when confirming setupIntent. I had a look at the stripe/stripe-react-native#1436 issue you mentioned above and see it's resolved, does that pave the way for a fix here? Appreciate there may be higher priorities but let me know if there's any plans to look at this, cheers!

@remonh87
Copy link
Member

@DavidEcclesPH yes this is indeed solved because we are up to date on Stripe. Sorry for forgetting to close this issue

@DavidEcclesPH
Copy link
Author

DavidEcclesPH commented Nov 26, 2024

Hi @remonh87 @jamesblasco we have parked this issue for a while but I am looking at it again now. The issue still remains in 11.3.0, I will try and give as much detail as possible here:

I have followed the code in the repo as far as possible (up to react side) and can see that both Stripe.instance.confirmPlatformPaySetupIntent and Stripe.instance.confirmPlatformPayPaymentIntent call the flutter method channel method confirmPlatformPay. When confirmPlatformPay is called with isPaymentIntent: true then the amount is shown on the google pay sheet, when isPaymentIntent: false the amount shown is 0, see screen shots:

paymentIntent:
image

setupIntent:
image

Following the code to the android side I can see that amount is passed in the params to the GooglePayLauncherFragment (via here ) from the method channel call however, amount is no longer part of the GooglePayParams which are passed to the confirmPlatformPay method.

This leads me to believe that amount is fetched from somewhere else, I believe in the react native code, however this is only working for a paymentIntent and not a setupIntent.

Any help you can provide here would be much appreciated as this has been blocked long term for us. I believe it makes using Googlepay for the purpose of paying a subscription nearly impossible as users will likely never click the pay button when the amount shows 0. Thanks in advance 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue is blocked by an external dependency issue bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants