Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paymentMethodOrder in PaymentElement #1862

Closed
Andrea951112 opened this issue Jul 22, 2024 · 7 comments
Closed

paymentMethodOrder in PaymentElement #1862

Andrea951112 opened this issue Jul 22, 2024 · 7 comments
Assignees
@remonh87
Labels
needs triage Needs triage
Milestone
next-release

Comments

@Andrea951112
Copy link

It is possible to add the paymentMethodOrder parameter to the PaymentElement object?

here the Stripe docs for this feature https://docs.stripe.com/js/elements_object/create_payment_element#payment_element_create-options-paymentMethodOrder
@Andrea951112 Andrea951112 added the needs triage Needs triage label Jul 22, 2024
@remonh87
Copy link
Member

this is available in flutter_stripe_web 6.0.0

@Andrea951112
Copy link
Author

@remonh87 sorry, but i do not see this implementation in flutter_stripe_web 6.0.0, is still not possible to configure the paymentMethodOrder in the PaymentELement. The PaymentElementOptions are created using only the "layout" parameter.

@Andrea951112
Copy link
Author

@remonh87 this implementation is missing in flutter_stripe_web 6.0.0

@remonh87
Copy link
Member

remonh87 commented Aug 8, 2024

it is here:

flutter_stripe/packages/stripe_js/lib/src/api/elements/payment_element_options.dart

Line 23 in 716dbdf

dynamic paymentMethodOrder,

@Andrea951112
Copy link
Author

yes, is present in the options object, but is missing the personalization in the PaymentElement object

js.PaymentElementOptions elementOptions() { return js.PaymentElementOptions(layout: widget.layout); }

@remonh87 remonh87 reopened this Aug 19, 2024
@remonh87 remonh87 added this to the next-release milestone Aug 19, 2024
@remonh87 remonh87 self-assigned this Aug 19, 2024
@remonh87
Copy link
Member

remonh87 commented Aug 19, 2024 •
edited
Loading

yes you are correct I added it to the options. Will be available next release

remonh87 pushed a commit that referenced this issue Aug 19, 2024
fix #1886 and #1862 by adding missing params to payment element
115a1f2
remonh87 added a commit that referenced this issue Aug 25, 2024
@remonh87
202408 fixes (#1893)
aa4e9a2 
* chore: upgrade dependencies to 3.24 and fix analyzer issues

* fix  score violations

* fix dependencies

* fix #1886 and #1862 by adding missing params to payment element

* chore: move android example to new gradle plugin and flutter gradle structure

---------

Co-authored-by: Remon <[email protected]>
@remonh87
Copy link
Member

fixed as part of release 6.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@remonh87 remonh87

Labels
needs triage Needs triage
Projects
None yet
Milestone
next-release
Development

No branches or pull requests
2 participants
@remonh87 @Andrea951112