feat: migrate js interop #1726
Merged
feat: migrate js interop #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jamesblasco
commented
Apr 18, 2024
jamesblasco
commented
- Migrates the stripe js to use the new dart js interop
jamesblasco
force-pushed
the
feat/new_interop
branch
from
5ac4cb8 to
85c74e0
Compare
remonh87
reviewed
Apr 18, 2024
There was a problem hiding this comment.
great job Jaime many thanks for this contribution.I just would like to discuss distribution
- If we merge this version we will go to a major upgrade and enforce people to use flutter 3.19 which I am fine with
- Or we create a pre-release from this branch and gather feedback. Disadvantage is potential merge conflicts.
What do you think?
remonh87
reviewed
Apr 18, 2024
| @@ -14,8 +14,8 @@ dependencies: | |||
| sdk: flutter | |||
| freezed_annotation: ^2.0.3 | |||
| stripe_platform_interface: ^10.1.1 | |||
| js: ^0.6.3 | |||
remonh87
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.