Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for platformPayCreatePaymentMethod error #1882

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

EduardDumitrescu
Copy link
Contributor

Refactor for -> #1879

Copy link
Member

@remonh87 remonh87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks looks good to me!

@remonh87
Copy link
Member

can you resolve the conflicts?

@EduardDumitrescu
Copy link
Contributor Author

can you resolve the conflicts?

Resolved merge conflicts 👍

@kanghuicong
Copy link

kanghuicong commented Sep 2, 2024

I also found an issue: when I cancel Apple Pay, this listener method is ineffective: paymentRequest.onCancel(() {}). It is necessary to change

void onCancel(void Function() callback) {
js.on('cancel', ([]) => callback);
}
to

import 'dart:js_util';
void onCancel(void Function() callback) {
_js.on('cancel', allowInterop(callback) as void Function(JSAny? v));
}

You might as well fix this issue at the same time. @EduardDumitrescu

@dioseltorre
Copy link

@EduardDumitrescu Looks like some tests failed. Any updates on this?

Eduard Dumitrescu added 2 commits September 25, 2024 09:44
… into mobile_pay_web

# Conflicts:
#	packages/stripe_js/CHANGELOG.md
#	packages/stripe_js/pubspec.yaml
#	packages/stripe_web/pubspec.yaml
… into mobile_pay_web

# Conflicts:
#	packages/stripe_js/lib/src/js/payment_requests/payment_request.dart
#	packages/stripe_web/pubspec.yaml
@EduardDumitrescu
Copy link
Contributor Author

EduardDumitrescu commented Oct 4, 2024

@EduardDumitrescu Looks like some tests failed. Any updates on this?

Hello, I don't quite understand what I'm supposed to do with the tests. Locally they work(because I have my key set in env) and the error on the pipeline is 'IntegrationError: Please call Stripe() with your publishable key. You used an empty string.' . Maybe the pipeline is supposed to set the a stripe key and for some reason it doesn't on this pr? @remonh87 Do you have any idea what must be done?

@remonh87 remonh87 merged commit dac2181 into flutter-stripe:main Oct 4, 2024
3 of 5 checks passed
@remonh87
Copy link
Member

remonh87 commented Oct 4, 2024

I decided to merge it because everything looks fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants