Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate sanctuary-type-identifiers #59

Merged
merged 1 commit into from
Feb 13, 2017
Merged

Conversation

Avaq
Copy link
Member

@Avaq Avaq commented Jan 5, 2017

This might be considered a breaking change, since it's a feature intended for interop with Sanctuary, and I believe it will break all S.is(Future, x) calls.

@codecov-io
Copy link

codecov-io commented Jan 5, 2017

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #59   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         889    889           
  Branches      214    214           
=====================================
  Hits          889    889
Impacted Files Coverage Δ
fluture.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc8386...02415d9. Read the comment docs.

@davidchambers
Copy link
Contributor

🌳

@Avaq Avaq force-pushed the sanctuary-type-identifiers branch from 89c6121 to 4af7933 Compare January 5, 2017 09:40
@Avaq Avaq added the breaking label Jan 7, 2017
@Avaq Avaq modified the milestone: 5.0.0 Jan 7, 2017
@Avaq Avaq force-pushed the sanctuary-type-identifiers branch 2 times, most recently from a5b56f4 to 9951b4b Compare February 13, 2017 09:48
@Avaq Avaq merged commit 8b63433 into master Feb 13, 2017
@Avaq Avaq deleted the sanctuary-type-identifiers branch February 14, 2017 14:05
Avaq added a commit that referenced this pull request Feb 23, 2017
Breaking changes

- #74 The argument order of `Future.or()` has been flipped
- #75 `Future.isForkable()` has been removed
- #75 `Future.fromForkable()` has been removed
- #75 `Future.cast()` has been removed

New features

- #70 Add a new ConcurrentFuture type

Bug fixes and improvements

- #4 #69 All curried functions now fail fast
- #59 Update Sanctuary interoperability
- #73 `Future.finally()` now runs `finally` computation when cancelled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants