From 20901e7c68489a369c3c7da8458eff22e41f71c0 Mon Sep 17 00:00:00 2001 From: Haytham AbuelFutuh Date: Wed, 20 Jan 2021 15:06:38 -0800 Subject: [PATCH] Deprecate Log Plugins (#94) Signed-off-by: Eduardo Apolinario --- flyteidl/clients/go/coreutils/logs/cloudwatch.go | 1 + flyteidl/clients/go/coreutils/logs/kubernetes.go | 1 + flyteidl/clients/go/coreutils/logs/logs.go | 1 + flyteidl/clients/go/coreutils/logs/stackdriver.go | 1 + 4 files changed, 4 insertions(+) diff --git a/flyteidl/clients/go/coreutils/logs/cloudwatch.go b/flyteidl/clients/go/coreutils/logs/cloudwatch.go index 2abdb8dc832..cab017091b9 100644 --- a/flyteidl/clients/go/coreutils/logs/cloudwatch.go +++ b/flyteidl/clients/go/coreutils/logs/cloudwatch.go @@ -36,6 +36,7 @@ func (s cloudwatchLogPlugin) GetTaskLog(podName, namespace, containerName, conta }, nil } +// Deprecated: Please use NewTemplateLogPlugin from github.com/lyft/flyteplugins/go/tasks/pluginmachinery/tasklog instead. func NewCloudwatchLogPlugin(region, groupName string) LogPlugin { return &cloudwatchLogPlugin{ region: region, diff --git a/flyteidl/clients/go/coreutils/logs/kubernetes.go b/flyteidl/clients/go/coreutils/logs/kubernetes.go index eec9c1d4209..ee791ac41e0 100644 --- a/flyteidl/clients/go/coreutils/logs/kubernetes.go +++ b/flyteidl/clients/go/coreutils/logs/kubernetes.go @@ -18,6 +18,7 @@ func (s kubernetesLogPlugin) GetTaskLog(podName, namespace, containerName, conta }, nil } +// Deprecated: Please use NewTemplateLogPlugin from github.com/lyft/flyteplugins/go/tasks/pluginmachinery/tasklog instead. func NewKubernetesLogPlugin(k8sURL string) LogPlugin { return &kubernetesLogPlugin{ k8sURL: k8sURL, diff --git a/flyteidl/clients/go/coreutils/logs/logs.go b/flyteidl/clients/go/coreutils/logs/logs.go index 13606a1b864..baf36631fd6 100644 --- a/flyteidl/clients/go/coreutils/logs/logs.go +++ b/flyteidl/clients/go/coreutils/logs/logs.go @@ -6,6 +6,7 @@ import ( "github.com/lyft/flyteidl/gen/pb-go/flyteidl/core" ) +// Deprecated: Please use Plugin interface from github.com/lyft/flyteplugins/go/tasks/pluginmachinery/tasklog instead. type LogPlugin interface { // Generates a TaskLog object given necessary computation information GetTaskLog(podName, namespace, containerName, containerID, logName string) (core.TaskLog, error) diff --git a/flyteidl/clients/go/coreutils/logs/stackdriver.go b/flyteidl/clients/go/coreutils/logs/stackdriver.go index dc154757162..91d4136b585 100644 --- a/flyteidl/clients/go/coreutils/logs/stackdriver.go +++ b/flyteidl/clients/go/coreutils/logs/stackdriver.go @@ -31,6 +31,7 @@ func (s *stackdriverLogPlugin) GetTaskLog(podName, namespace, containerName, con }, nil } +// Deprecated: Please use NewTemplateLogPlugin from github.com/lyft/flyteplugins/go/tasks/pluginmachinery/tasklog instead. func NewStackdriverLogPlugin(gcpProject, logResource string) LogPlugin { return &stackdriverLogPlugin{ gcpProject: gcpProject,