From 4e24e914c06d127c3559f59b03616f1a85743a24 Mon Sep 17 00:00:00 2001 From: Future-Outlier Date: Tue, 17 Dec 2024 15:28:16 +0800 Subject: [PATCH] better comments Signed-off-by: Future-Outlier --- flytepropeller/pkg/controller/nodes/task/handler.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/flytepropeller/pkg/controller/nodes/task/handler.go b/flytepropeller/pkg/controller/nodes/task/handler.go index ef24535b3c..d2d538549d 100644 --- a/flytepropeller/pkg/controller/nodes/task/handler.go +++ b/flytepropeller/pkg/controller/nodes/task/handler.go @@ -550,7 +550,7 @@ func (t Handler) invokePlugin(ctx context.Context, p pluginCore.Plugin, tCtx *ta // is actually present. switch pluginTrns.pInfo.Phase() { case pluginCore.PhaseSuccess: - // This is to prevent the console from potentially checking the deck URI that does not exist if in final phase(PhaseSuccess). + // This is for backward compatibility with older Flytekit versions. if !deckEnabled { err = pluginTrns.AddDeckURIIfDeckExists(ctx, tCtx) } @@ -600,8 +600,7 @@ func (t Handler) invokePlugin(ctx context.Context, p pluginCore.Plugin, tCtx *ta case pluginCore.PhaseRetryableFailure: fallthrough case pluginCore.PhasePermanentFailure: - // This is to prevent the console from potentially checking the deck URI that does not exist if in final - // phase(PhaseFailure). + // This is for backward compatibility with older Flytekit versions. if !deckEnabled { err = pluginTrns.AddDeckURIIfDeckExists(ctx, tCtx) }