Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [flytekit] Support typing.Tuple for multiple returns #1029

Closed
wild-endeavor opened this issue May 13, 2021 · 0 comments
Closed

[BUG] [flytekit] Support typing.Tuple for multiple returns #1029

wild-endeavor opened this issue May 13, 2021 · 0 comments
Assignees
Labels
bug Something isn't working flytekit FlyteKit Python related issue
Milestone

Comments

@wild-endeavor
Copy link
Contributor

Describe the bug
Currently, if a task returns two or more outputs, users are expected to declare those return signatures as

def t1() -> (int, int):
  ...

This is fine but is not idiomatic and doesn't pass mypy. The correct thing to support is:

def t1() -> typing.Tuple[int, int]:
  ...
@wild-endeavor wild-endeavor added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels May 13, 2021
@wild-endeavor wild-endeavor changed the title [BUG] [flytekit] Support typing.Tuple [BUG] [flytekit] Support typing.Tuple for multiple returns May 13, 2021
@wild-endeavor wild-endeavor added the flytekit FlyteKit Python related issue label May 13, 2021
@wild-endeavor wild-endeavor removed the untriaged This issues has not yet been looked at by the Maintainers label May 26, 2021
@EngHabu EngHabu added this to the 0.18.0 milestone Aug 31, 2021
@pingsutw pingsutw self-assigned this Aug 31, 2021
@kumare3 kumare3 closed this as completed Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue
Projects
None yet
Development

No branches or pull requests

4 participants