Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support branch nodes in FlyteWorkflow.fetch #1116

Closed
cosmicBboy opened this issue Jun 10, 2021 · 3 comments
Closed

Support branch nodes in FlyteWorkflow.fetch #1116

cosmicBboy opened this issue Jun 10, 2021 · 3 comments
Assignees
@wild-endeavor
Labels
bug Something isn't working Epic: Interactive Experience Everything from FlyteRemote to how to better support Jupyter/vscode development with Flyte flytekit FlyteKit Python related issue
Milestone
0.19.3 - Feb 2021

Comments

@cosmicBboy
Copy link
Contributor

cosmicBboy commented Jun 10, 2021 •
edited
Loading

SdkWorkflow.fetch (the legacy control plane class) doesn't support fetching workflows that have branch nodes. This issue should address this issue in the equivalent new control plane class https://github.com/flyteorg/flytekit/blob/master/flytekit/control_plane/workflow.py#L17

For more context see conversation in https://flyte-org.slack.com/archives/CNMKCU6FR/p1623320382058400
@cosmicBboy cosmicBboy added the bug Something isn't working label Jun 10, 2021
@fediazgon fediazgon mentioned this issue Jul 1, 2021
Merged
8 tasks
@kanterov
Copy link
Contributor

@cosmicBboy are branch nodes going to be supported in FlyteRemote?

@cosmicBboy
Copy link
Contributor Author

@kanterov we'll make it so! if not in the MVP release of the remote module, then as a quick follow-up

@EngHabu EngHabu added flytekit FlyteKit Python related issue bugSquash-Cascade labels Aug 25, 2021
@EngHabu EngHabu added this to the 0.18.0 milestone Aug 31, 2021
@eapolinario eapolinario modified the milestones: 0.18.0, 0.18.1 Oct 6, 2021
@EngHabu EngHabu modified the milestones: 0.18.1, 0.18.2 Nov 3, 2021
@wild-endeavor wild-endeavor modified the milestones: 0.18.2, 0.19.0 - Eagle Dec 1, 2021
@kumare3
Copy link
Contributor

kumare3 commented Feb 1, 2022

@wild-endeavor I think you merged this right?

@wild-endeavor wild-endeavor mentioned this issue Feb 16, 2022
Merged
8 tasks
@wild-endeavor wild-endeavor added the Epic: Interactive Experience Everything from FlyteRemote to how to better support Jupyter/vscode development with Flyte label Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wild-endeavor wild-endeavor

Labels
bug Something isn't working Epic: Interactive Experience Everything from FlyteRemote to how to better support Jupyter/vscode development with Flyte flytekit FlyteKit Python related issue
Projects
None yet
Milestone
0.19.3 - Feb 2021
Development

No branches or pull requests
6 participants
@EngHabu @kanterov @eapolinario @cosmicBboy @wild-endeavor @kumare3