Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] FlyteConsole Launch form Auth options should be updated #1723

Closed
2 tasks done
EngHabu opened this issue Oct 20, 2021 · 3 comments
Closed
2 tasks done

[BUG] FlyteConsole Launch form Auth options should be updated #1723

EngHabu opened this issue Oct 20, 2021 · 3 comments
Labels
bug Something isn't working ui Admin console user interface
Milestone
0.19.2 - Jan 2021

Comments

@EngHabu
Copy link
Contributor

EngHabu commented Oct 20, 2021

Describe the bug

The current proto the UI uses to fill in IAM and KSA allows only one of them to be set. This proto has been deprecated in favor of a new proto.

The new proto supports passing both IAM Role and Kubernetes Service Account at the same time...
https://github.com/flyteorg/flyteidl/blob/f4809c1a52073ec80de41be109bccc6331cdbac3/protos/flyteidl/core/security.proto#L60-L72

Expected behavior

Allow users to set both IAM and KSA. And use the new proto to fill them in

Additional context to reproduce

Blocked by: #1722

Screenshots

image

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@EngHabu EngHabu added bug Something isn't working ui Admin console user interface untriaged This issues has not yet been looked at by the Maintainers labels Oct 20, 2021
@EngHabu EngHabu added this to the 0.18.2 milestone Oct 20, 2021
@jsonporter
Copy link

Fixed with flyteorg/flyteconsole#236

@EngHabu EngHabu reopened this Dec 10, 2021
@EngHabu
Copy link
Contributor Author

EngHabu commented Dec 10, 2021

This is not fixed... Admin now respects SecurityContext and the UI can be updated to leverage that... let's discuss if the bug is not clear...

@EngHabu EngHabu modified the milestones: 0.18.2, 0.19.1 - Jan 2021 Jan 4, 2022
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Jan 11, 2022
@jsonporter
Copy link

Closing. Merged with flyteorg/flyteconsole#253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ui Admin console user interface
Projects
None yet
Milestone
0.19.2 - Jan 2021
Development

No branches or pull requests
3 participants
@EngHabu @kumare3 @jsonporter