Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] configurations settings listed in the doc #1752

Open
2 tasks done
veggiemonk opened this issue Oct 27, 2021 · 8 comments
Open
2 tasks done

[Docs] configurations settings listed in the doc #1752

veggiemonk opened this issue Oct 27, 2021 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation flytepropeller stale

Comments

@veggiemonk
Copy link
Contributor

Description

Hi team, last time I had to sync our config, it was done manually.
There are some good documentation here for Flyte propeller performances and there is a some config examples for those willing to dig in the YAML/code.

What I propose is a way to generate all configurations with the defaults set and, hopefully some comments/doc, which could also be kept in sync on the website.

Before discussion solution, I would like to know your thoughts on this

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@veggiemonk veggiemonk added documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers labels Oct 27, 2021
@kumare3
Copy link
Contributor

kumare3 commented Oct 28, 2021

@veggiemonk this is intact in progress

@pingsutw pingsutw self-assigned this Dec 8, 2021
@pingsutw
Copy link
Member

pingsutw commented Dec 20, 2021

@kumare3 It's quite similar to #819. Do I need to create another PR to generate all the default config values with comments into a YAML file? and users can just update this YAML for their needs.

@kumare3
Copy link
Contributor

kumare3 commented Dec 22, 2021

@pingsutw can we do that? ya it would be pretty cool to do - flytepropeller config generate-default?

@pingsutw
Copy link
Member

Yeah, I think we can do that, let me try it.

@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Jan 11, 2022
@marc-union
Copy link
Contributor

@pingsutw Are you able to work on this or can we reassign it?

@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 27, 2023
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 3, 2023
Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation flytepropeller stale
Projects
None yet
Development

No branches or pull requests

6 participants